pwm: tiecap: Drop .free() callback

ecap_pwm_free is only called when a consumer releases the PWM (using
pwm_put() or pwm_free()). The consumer is expected to disable the PWM
before doing that. It's not clear if a warning about that is justified, but
if it is this is independent of the actual driver and can better be done in
the core. Also if there is a good reason it's wrong to disable the hardware
and so the call to pm_runtime_put_sync() should be dropped. Moreover there
is no matching pwm_runtime_get call and so the runtime usage counter might
become negative.

Fixes: 8e0cb05b3b75 ("pwm: pwm-tiecap: PWM driver support for ECAP APWM")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index f40975fcb195a9b0cba8d21c4783327c53e28194..027dd01425584e118c2df54c89f272eb9e106675 100644 (file)
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -168,16 +168,7 @@ static void ecap_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
        pm_runtime_put_sync(pc->chip.dev);
 }
 
-static void ecap_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
-{
-       if (pwm_is_enabled(pwm)) {
-               dev_warn(chip->dev, "Removing PWM device without disabling\n");
-               pm_runtime_put_sync(chip->dev);
-       }
-}
-
 static const struct pwm_ops ecap_pwm_ops = {
-       .free = ecap_pwm_free,
        .config = ecap_pwm_config,
        .set_polarity = ecap_pwm_set_polarity,
        .enable = ecap_pwm_enable,