staging: r8188eu: use standard multicast addr check
authorMartin Kaiser <martin@kaiser.cx>
Sun, 23 Oct 2022 17:08:04 +0000 (19:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Oct 2022 17:22:51 +0000 (19:22 +0200)
Use is_multicast_ether_addr to check for a multicast address instead of
reimplementing this check in the driver.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221023170808.46233-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_sta_mgt.c
drivers/staging/r8188eu/include/wifi.h

index bbde5c03f9ae0ec1cc63065918178a7461171459..51324e708697f704638ff21210662737148e0fe0 100644 (file)
@@ -404,7 +404,7 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)
        if (!hwaddr)
                return NULL;
 
-       if (IS_MCAST(hwaddr))
+       if (is_multicast_ether_addr(hwaddr))
                addr = bc_addr;
        else
                addr = hwaddr;
index 381385a7e1189d13e7e9117c2bbc9e1634e543bd..fdb7c1bf3573cd088540e3e30d0227a70a7ad68b 100644 (file)
@@ -236,11 +236,6 @@ enum WIFI_REG_DOMAIN {
 
 #define GetAddr4Ptr(pbuf)      ((unsigned char *)((size_t)(pbuf) + 24))
 
-static inline bool IS_MCAST(unsigned char *da)
-{
-       return (*da) & 0x01;
-}
-
 static inline unsigned char *get_da(unsigned char *pframe)
 {
        unsigned char   *da;