wifi: ath12k: fix recovery fail while firmware crash when doing channel switch
authorWen Gong <quic_wgong@quicinc.com>
Tue, 5 Sep 2023 10:52:29 +0000 (06:52 -0400)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 28 Sep 2023 15:01:12 +0000 (18:01 +0300)
When firmware crashed while channel switch running, recovery starts in
ath12k. Then ieee80211_sta_connection_lost() will be called by function
ieee80211_restart_work() in mac80211. And then many WMI command timeout
because firmware is crashed. Each WMI command cost 3 seconds, then the
total time will be large and leads recovery fail.

Hence change to set value ATH12K_FLAG_CRASH_FLUSH early and then
ath12k_wmi_cmd_send() will not wait 3 seconds, then recovery will be
started quickly and success.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230905105229.10090-1-quic_wgong@quicinc.com
drivers/net/wireless/ath/ath12k/core.c

index c6fb1e435d86b7b6dbce1518a2ef4d0a53d76355..9a9a471ff130cdcd25429243e62735e5be2efdeb 100644 (file)
@@ -735,6 +735,9 @@ static void ath12k_core_pre_reconfigure_recovery(struct ath12k_base *ab)
        ab->stats.fw_crash_counter++;
        spin_unlock_bh(&ab->base_lock);
 
+       if (ab->is_reset)
+               set_bit(ATH12K_FLAG_CRASH_FLUSH, &ab->dev_flags);
+
        for (i = 0; i < ab->num_radios; i++) {
                pdev = &ab->pdevs[i];
                ar = pdev->ar;