phy: qcom-qmp-pcie: add pcs_misc sanity check

Make sure that the (otherwise) optional pcs_misc IO region has been
provided in case the configuration specifies a corresponding
initialisation table to avoid crashing with malformed device trees.

Note that the related debug message is now superfluous as the region is
only used when the configuration has a pcs_misc table.

Fixes: 421c9a0e9731 ("phy: qcom: qmp: Add SDM845 PCIe QMP PHY support")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20220916102340.11520-2-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index e6bffb0e2da322228d187e09c68f9d07c4521af1..05e73625a619310add399275d82a9c838d2b6621 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -2300,8 +2300,10 @@ static int qmp_pcie_create(struct device *dev, struct device_node *np, int id,
            of_device_is_compatible(dev->of_node, "qcom,ipq6018-qmp-pcie-phy"))
                qphy->pcs_misc = qphy->pcs + 0x400;
 
-       if (!qphy->pcs_misc)
-               dev_vdbg(dev, "PHY pcs_misc-reg not used\n");
+       if (!qphy->pcs_misc) {
+               if (cfg->pcs_misc_tbl || cfg->pcs_misc_tbl_sec)
+                       return -EINVAL;
+       }
 
        qphy->pipe_clk = devm_get_clk_from_child(dev, np, NULL);
        if (IS_ERR(qphy->pipe_clk)) {