media: vicodec: Do not zero reserved fields
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 11 Jan 2021 14:54:44 +0000 (15:54 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 12:21:44 +0000 (13:21 +0100)
Core code already clears reserved fields of struct
v4l2_pix_format_mplane, check commit 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
v4l2_plane_pix_format reserved fields").

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/test-drivers/vicodec/vicodec-core.c

index 025f3ff77302c72628073a4f70693c5da3121d8f..33f1c893c1b64e7ed14f35c85773884be10bc9b7 100644 (file)
@@ -811,9 +811,6 @@ static int vidioc_g_fmt(struct vicodec_ctx *ctx, struct v4l2_format *f)
                pix_mp->xfer_func = ctx->state.xfer_func;
                pix_mp->ycbcr_enc = ctx->state.ycbcr_enc;
                pix_mp->quantization = ctx->state.quantization;
-               memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
-               memset(pix_mp->plane_fmt[0].reserved, 0,
-                      sizeof(pix_mp->plane_fmt[0].reserved));
                break;
        default:
                return -EINVAL;
@@ -886,8 +883,6 @@ static int vidioc_try_fmt(struct vicodec_ctx *ctx, struct v4l2_format *f)
                        info->sizeimage_mult / info->sizeimage_div;
                if (pix_mp->pixelformat == V4L2_PIX_FMT_FWHT)
                        plane->sizeimage += sizeof(struct fwht_cframe_hdr);
-               memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
-               memset(plane->reserved, 0, sizeof(plane->reserved));
                break;
        default:
                return -EINVAL;