usb: gadget: uvc: drop unnecessary check for always set req

The pump function is running in an while(1) loop. The only case this
loop will be escaped is the two breaks. In both cases the req is valid.
Therefor the check for an not set req can be dropped and setting the req
to NULL does also has never any effect.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Link: https://lore.kernel.org/r/20240214-uvc-gadget-cleanup-v1-1-de6d78780459@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index dd3241fc6939d6fa0e0a23a36469e5f137164e3a..b17c61c9326529a728f1087729fbb7c1b9553471 100644 (file)
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -623,14 +623,7 @@ static void uvcg_video_pump(struct work_struct *work)
                        uvcg_queue_cancel(queue, 0);
                        break;
                }
-
-               /* The request is owned by  the endpoint / ready list. */
-               req = NULL;
        }
-
-       if (!req)
-               return;
-
        spin_lock_irqsave(&video->req_lock, flags);
        if (video->is_enabled)
                list_add_tail(&req->list, &video->req_free);