usb: common: usb-conn-gpio: Set last role to unknown before initial detection

Currently if we bootup a device without cable connected, then
usb-conn-gpio won't call set_role() since last_role is same as
current role. This happens because during probe last_role gets
initialised to zero.

To avoid this, added a new constant in enum usb_role, last_role
is set to USB_ROLE_UNKNOWN before performing initial detection.

While at it, also handle default case for the usb_role switch
in cdns3, intel-xhci-usb-role-switch & musb/jz4740 to avoid
build warnings.

Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Message-ID: <1685544074-17337-1-git-send-email-quic_prashk@quicinc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
index dbcdf3b24b47793caffd28ff1ed542c31c2ba133..69d2921f2d3b5a469d043166dfcd33b580f5b8d1 100644 (file)
--- a/drivers/usb/cdns3/core.c
+++ b/drivers/usb/cdns3/core.c
@@ -252,6 +252,8 @@ static enum usb_role cdns_hw_role_state_machine(struct cdns *cdns)
                if (!vbus)
                        role = USB_ROLE_NONE;
                break;
+       default:
+               break;
        }
 
        dev_dbg(cdns->dev, "role %d -> %d\n", cdns->role, role);

diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
index 766005d20baefde32a69e78a84fc6f39e33b9241..d0e8624c7dfea3cfc0dcb55abe63f800390fe35f 100644 (file)
--- a/drivers/usb/common/usb-conn-gpio.c
+++ b/drivers/usb/common/usb-conn-gpio.c
@@ -257,6 +257,9 @@ static int usb_conn_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, info);
        device_set_wakeup_capable(&pdev->dev, true);
 
+       /* Set last role to unknown before performing the initial detection */
+       info->last_role = USB_ROLE_UNKNOWN;
+
        /* Perform initial detection */
        usb_conn_queue_dwork(info, 0);
 

diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
index 5aabdd7e2511d7d953e9143877de92e9a0138a01..6d880c4cce36e2753af96b0991324f5a06192739 100644 (file)
--- a/drivers/usb/musb/jz4740.c
+++ b/drivers/usb/musb/jz4740.c
@@ -95,6 +95,8 @@ static int jz4740_musb_role_switch_set(struct usb_role_switch *sw,
        case USB_ROLE_HOST:
                atomic_notifier_call_chain(&phy->notifier, USB_EVENT_ID, phy);
                break;
+       default:
+               break;
        }
 
        return 0;

diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c b/drivers/usb/roles/intel-xhci-usb-role-switch.c
index e5c6c413a075b6e9c8734d029f20fc558ec69c92..8e2997d65f115dd64a6ef7db3ccd99f88cf8286f 100644 (file)
--- a/drivers/usb/roles/intel-xhci-usb-role-switch.c
+++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c
@@ -97,6 +97,8 @@ static int intel_xhci_usb_set_role(struct usb_role_switch *sw,
                val |= SW_VBUS_VALID;
                drd_config = DRD_CONFIG_STATIC_DEVICE;
                break;
+       default:
+               break;
        }
        val |= SW_IDPIN_EN;
        if (data->enable_sw_switch) {

diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
index b5deafd91f67bb58f04c4c9189bf37b1fcfe28f1..65e790a28913eee9b78392646250c5f3808116fb 100644 (file)
--- a/include/linux/usb/role.h
+++ b/include/linux/usb/role.h
@@ -11,6 +11,7 @@ enum usb_role {
        USB_ROLE_NONE,
        USB_ROLE_HOST,
        USB_ROLE_DEVICE,
+       USB_ROLE_UNKNOWN,
 };
 
 typedef int (*usb_role_switch_set_t)(struct usb_role_switch *sw,