net: ethernet: sunplus: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
index c499a14314f13d03fe339b4423b1cb318889151d..391a1bc7f44639fd4af5d2f8a5cbdcc8fefec6d7 100644 (file)
--- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -511,7 +511,7 @@ out_clk_disable:
        return ret;
 }
 
-static int spl2sw_remove(struct platform_device *pdev)
+static void spl2sw_remove(struct platform_device *pdev)
 {
        struct spl2sw_common *comm;
        int i;
@@ -538,8 +538,6 @@ static int spl2sw_remove(struct platform_device *pdev)
        spl2sw_mdio_remove(comm);
 
        clk_disable_unprepare(comm->clk);
-
-       return 0;
 }
 
 static const struct of_device_id spl2sw_of_match[] = {
@@ -551,7 +549,7 @@ MODULE_DEVICE_TABLE(of, spl2sw_of_match);
 
 static struct platform_driver spl2sw_driver = {
        .probe = spl2sw_probe,
-       .remove = spl2sw_remove,
+       .remove_new = spl2sw_remove,
        .driver = {
                .name = "sp7021_emac",
                .of_match_table = spl2sw_of_match,