projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2ba4e3b
)
soc: mediatek: mtk-svs: fix passing zero to 'PTR_ERR'
author
Roger Lu
<roger.lu@mediatek.com>
Thu, 16 Feb 2023 13:25:43 +0000
(21:25 +0800)
committer
Matthias Brugger
<matthias.bgg@gmail.com>
Thu, 30 Mar 2023 09:29:42 +0000
(11:29 +0200)
nvmem_cell_get() cannot return NULL so checking for NULL is wrong here.
Signed-off-by: Roger Lu <roger.lu@mediatek.com>
Fixes: 6c7174fd90a4690 ("soc: mediatek: mtk-svs: use svs get efuse common function")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link:
https://lore.kernel.org/r/202302160720.N64SWT4l-lkp@intel.com/
Link:
https://lore.kernel.org/r/20230216132543.814-1-roger.lu@mediatek.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
drivers/soc/mediatek/mtk-svs.c
patch
|
blob
|
history
diff --git
a/drivers/soc/mediatek/mtk-svs.c
b/drivers/soc/mediatek/mtk-svs.c
index a7eb019b5157dde7dfa51b3e46740832b208b646..8127fb6d587bf0f1207525caf21198fb4ecf2d9a 100644
(file)
--- a/
drivers/soc/mediatek/mtk-svs.c
+++ b/
drivers/soc/mediatek/mtk-svs.c
@@
-1726,7
+1726,7
@@
static int svs_get_efuse_data(struct svs_platform *svsp,
struct nvmem_cell *cell;
cell = nvmem_cell_get(svsp->dev, nvmem_cell_name);
- if (IS_ERR
_OR_NULL
(cell)) {
+ if (IS_ERR(cell)) {
dev_err(svsp->dev, "no \"%s\"? %ld\n",
nvmem_cell_name, PTR_ERR(cell));
return PTR_ERR(cell);