ASoC: Intel: bytcr_rt5640: Utilize dev_err_probe() to avoid log saturation
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 7 Oct 2021 16:57:15 +0000 (19:57 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 11 Oct 2021 13:58:49 +0000 (14:58 +0100)
dev_err_probe() avoids printing into log when the deferred probe is invoked.
This is possible when clock provider is pending to appear.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211007165715.27463-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5640.c

index 2e7d45f0f05d22bf5456135d1ce16d7c6b0be1e0..a0c5f0e9c22a1734b46a79b57ba2509b13fdbbb4 100644 (file)
@@ -1617,8 +1617,8 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
                                                           "headset-mic-detect", GPIOD_IN,
                                                           "headset-mic-detect");
                if (IS_ERR(priv->hsmic_detect)) {
-                       ret_val = PTR_ERR(priv->hsmic_detect);
-                       dev_err_probe(dev, ret_val, "getting hsmic-detect GPIO\n");
+                       ret_val = dev_err_probe(dev, PTR_ERR(priv->hsmic_detect),
+                                               "getting hsmic-detect GPIO\n");
                        goto err_device;
                }
        }
@@ -1645,12 +1645,8 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) {
                priv->mclk = devm_clk_get_optional(dev, "pmc_plt_clk_3");
                if (IS_ERR(priv->mclk)) {
-                       ret_val = PTR_ERR(priv->mclk);
-
-                       dev_err(dev,
-                               "Failed to get MCLK from pmc_plt_clk_3: %d\n",
-                               ret_val);
-
+                       ret_val = dev_err_probe(dev, PTR_ERR(priv->mclk),
+                                               "Failed to get MCLK from pmc_plt_clk_3\n");
                        goto err;
                }
                /*