openrisc: traps: Remove calls to show_registers before die
authorStafford Horne <shorne@gmail.com>
Thu, 11 Apr 2024 17:42:50 +0000 (18:42 +0100)
committerStafford Horne <shorne@gmail.com>
Mon, 15 Apr 2024 14:20:39 +0000 (15:20 +0100)
The die function calls show_registers unconditionally.  Remove calls to
show_registers before calling die to avoid printing all registers and
stack status two times during a crash.

This was found when testing kernel trap and floating point exception
handling.

Signed-off-by: Stafford Horne <shorne@gmail.com>
arch/openrisc/kernel/traps.c

index 6d0fee912747bb70eda55c179cd1eacf921878a0..88fe27e4c10c7e0b6d302e97b7a63982835295d8 100644 (file)
@@ -212,7 +212,6 @@ asmlinkage void do_unaligned_access(struct pt_regs *regs, unsigned long address)
                force_sig_fault(SIGBUS, BUS_ADRALN, (void __user *)address);
        } else {
                pr_emerg("KERNEL: Unaligned Access 0x%.8lx\n", address);
-               show_registers(regs);
                die("Die:", regs, address);
        }
 
@@ -225,7 +224,6 @@ asmlinkage void do_bus_fault(struct pt_regs *regs, unsigned long address)
                force_sig_fault(SIGBUS, BUS_ADRERR, (void __user *)address);
        } else {                /* Kernel mode */
                pr_emerg("KERNEL: Bus error (SIGBUS) 0x%.8lx\n", address);
-               show_registers(regs);
                die("Die:", regs, address);
        }
 }
@@ -421,7 +419,6 @@ asmlinkage void do_illegal_instruction(struct pt_regs *regs,
        } else {                /* Kernel mode */
                pr_emerg("KERNEL: Illegal instruction (SIGILL) 0x%.8lx\n",
                         address);
-               show_registers(regs);
                die("Die:", regs, address);
        }
 }