backlight: mp3309c: Use dev_err_probe() instead of dev_err()

Replace dev_err() with dev_err_probe().

This helps in simplifing code and standardizing the error output.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Flavio Suligoi <f.suligoi@asem.it>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240208184313.2224579-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c
index 397f35dafc5e55d91c15b23f8e9a4b6dfbae8ce0..426e9f2356ad08908d897f64131acce97b7ad5b0 100644 (file)
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -208,10 +208,8 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
        unsigned int num_levels, tmp_value;
        struct device *dev = chip->dev;
 
-       if (!dev_fwnode(dev)) {
-               dev_err(dev, "failed to get firmware node\n");
-               return -ENODEV;
-       }
+       if (!dev_fwnode(dev))
+               return dev_err_probe(dev, -ENODEV, "failed to get firmware node\n");
 
        /*
         * Dimming mode: the MP3309C provides two dimming control mode:
@@ -287,8 +285,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
        if (ret)
                pdata->default_brightness = pdata->max_brightness;
        if (pdata->default_brightness > pdata->max_brightness) {
-               dev_err(chip->dev,
-                       "default brightness exceeds max brightness\n");
+               dev_err_probe(dev, -ERANGE, "default brightness exceeds max brightness\n");
                pdata->default_brightness = pdata->max_brightness;
        }
 
@@ -329,16 +326,15 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
 
 static int mp3309c_probe(struct i2c_client *client)
 {
-       struct mp3309c_platform_data *pdata = dev_get_platdata(&client->dev);
+       struct device *dev = &client->dev;
+       struct mp3309c_platform_data *pdata = dev_get_platdata(dev);
        struct mp3309c_chip *chip;
        struct backlight_properties props;
        struct pwm_state pwmstate;
        int ret;
 
-       if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
-               dev_err(&client->dev, "failed to check i2c functionality\n");
-               return -EOPNOTSUPP;
-       }
+       if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
+               return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n");
 
        chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)