projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
74248b5
)
rtc: st-lpc: Add missing clk_disable_unprepare in st_rtc_probe()
author
Gaosheng Cui
<cuigaosheng1@huawei.com>
Wed, 23 Nov 2022 01:48:05 +0000
(09:48 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:37 +0000
(13:14 +0100)
[ Upstream commit
5fb733d7bd6949e90028efdce8bd528c6ab7cf1e
]
The clk_disable_unprepare() should be called in the error handling
of clk_get_rate(), fix it.
Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link:
https://lore.kernel.org/r/20221123014805.1993052-1-cuigaosheng1@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-st-lpc.c
patch
|
blob
|
history
diff --git
a/drivers/rtc/rtc-st-lpc.c
b/drivers/rtc/rtc-st-lpc.c
index bdb20f63254e26cafdeea10330b4ecf3d944b543..0f8e4231098ef1b856906a484a17585f8be94e2a 100644
(file)
--- a/
drivers/rtc/rtc-st-lpc.c
+++ b/
drivers/rtc/rtc-st-lpc.c
@@
-238,6
+238,7
@@
static int st_rtc_probe(struct platform_device *pdev)
rtc->clkrate = clk_get_rate(rtc->clk);
if (!rtc->clkrate) {
+ clk_disable_unprepare(rtc->clk);
dev_err(&pdev->dev, "Unable to fetch clock rate\n");
return -EINVAL;
}