staging: wfx: fix support for BSS_CHANGED_KEEP_ALIVE

Chip firmware is able to send periodic null frames to keep the
association with the AP.

The driver arbitrary set this period to 30sec. We prefer to rely on
BSS_CHANGED_KEEP_ALIVE that provide a true value.

Note that if BSS_CHANGED_KEEP_ALIVE is not received, we just disable
keep_alive feature. It is not very disturbing since AP will probably
ping the station before to disconnect it.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200410133239.438347-9-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 7693ce22f300fdf589266a1fb7ecb079c3c356ab..67e16c4358485886ed8d127d5f7c8b96a7ab09a3 100644 (file)
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -646,7 +646,7 @@ static void wfx_join_finalize(struct wfx_vif *wvif,
 
        if (!info->ibss_joined) {
                wvif->state = WFX_STATE_STA;
-               hif_keep_alive_period(wvif, 30 /* sec */);
+               hif_keep_alive_period(wvif, 0);
                hif_set_bss_params(wvif, &wvif->bss_params);
                hif_set_beacon_wakeup_period(wvif, info->dtim_period,
                                             info->dtim_period);
@@ -728,6 +728,10 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw,
                                 __func__);
        }
 
+       if (changed & BSS_CHANGED_KEEP_ALIVE)
+               hif_keep_alive_period(wvif, info->max_idle_period *
+                                           USEC_PER_TU / USEC_PER_MSEC);
+
        if (changed & BSS_CHANGED_ASSOC ||
            changed & BSS_CHANGED_ERP_CTS_PROT ||
            changed & BSS_CHANGED_ERP_PREAMBLE) {