iomap: Fix possible overflow condition in iomap_write_delalloc_scan
authorRitesh Harjani (IBM) <ritesh.list@gmail.com>
Mon, 10 Jul 2023 21:12:22 +0000 (14:12 -0700)
committerRitesh Harjani (IBM) <ritesh.list@gmail.com>
Tue, 25 Jul 2023 05:25:55 +0000 (10:55 +0530)
folio_next_index() returns an unsigned long value which left shifted
by PAGE_SHIFT could possibly cause an overflow on 32-bit system. Instead
use folio_pos(folio) + folio_size(folio), which does this correctly.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
fs/iomap/buffered-io.c

index 85159e5b3d1d4378ef9eb91862dd99d363a88f89..38e95302bd6ad51bcdce4c03328fc8350d0efdf0 100644 (file)
@@ -934,7 +934,7 @@ static int iomap_write_delalloc_scan(struct inode *inode,
                         * the end of this data range, not the end of the folio.
                         */
                        *punch_start_byte = min_t(loff_t, end_byte,
-                                       folio_next_index(folio) << PAGE_SHIFT);
+                                       folio_pos(folio) + folio_size(folio));
                }
 
                /* move offset to start of next folio in range */