ROSE: Remove unused code and clean up some inconsistent indenting
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Sat, 7 May 2022 03:42:07 +0000 (11:42 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 May 2022 00:19:27 +0000 (17:19 -0700)
Eliminate the follow smatch warning:

net/rose/rose_route.c:1136 rose_node_show() warn: inconsistent
indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220507034207.18651-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rose/rose_route.c

index e2e6b6b7857892c3d4f17ea4d4750acee01b2cbc..fee6409c2bb383abe4428dff6f70345d1445387b 100644 (file)
@@ -1128,22 +1128,15 @@ static int rose_node_show(struct seq_file *seq, void *v)
                seq_puts(seq, "address    mask n neigh neigh neigh\n");
        else {
                const struct rose_node *rose_node = v;
-               /* if (rose_node->loopback) {
-                       seq_printf(seq, "%-10s %04d 1 loopback\n",
-                                  rose2asc(rsbuf, &rose_node->address),
-                                  rose_node->mask);
-               } else { */
-                       seq_printf(seq, "%-10s %04d %d",
-                                  rose2asc(rsbuf, &rose_node->address),
-                                  rose_node->mask,
-                                  rose_node->count);
-
-                       for (i = 0; i < rose_node->count; i++)
-                               seq_printf(seq, " %05d",
-                                       rose_node->neighbour[i]->number);
-
-                       seq_puts(seq, "\n");
-               /* } */
+               seq_printf(seq, "%-10s %04d %d",
+                          rose2asc(rsbuf, &rose_node->address),
+                          rose_node->mask,
+                          rose_node->count);
+
+               for (i = 0; i < rose_node->count; i++)
+                       seq_printf(seq, " %05d", rose_node->neighbour[i]->number);
+
+               seq_puts(seq, "\n");
        }
        return 0;
 }