blk-throttle: print signed value 'carryover_bytes/ios' for user

'carryover_bytes/ios' can be negative, indicate that some bio is
dispatched in advance within slice while configuration is updated.
Print a huge value is not user-friendly.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230816012708.1193747-2-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 7397ff199d6695e40f4e181f91982d4ec8870252..5184f17f512909a805cc2967d8ddead457108c64 100644 (file)
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -816,7 +816,7 @@ static void tg_update_carryover(struct throtl_grp *tg)
                __tg_update_carryover(tg, WRITE);
 
        /* see comments in struct throtl_grp for meaning of these fields. */
-       throtl_log(&tg->service_queue, "%s: %llu %llu %u %u\n", __func__,
+       throtl_log(&tg->service_queue, "%s: %lld %lld %d %d\n", __func__,
                   tg->carryover_bytes[READ], tg->carryover_bytes[WRITE],
                   tg->carryover_ios[READ], tg->carryover_ios[WRITE]);
 }

diff --git a/block/blk-throttle.h b/block/blk-throttle.h
index d1ccbfe9f797882c05256a5780fa151093174c44..bffbc9cfc8ab6bac79ad4d3cff04622ce1f852d8 100644 (file)
--- a/block/blk-throttle.h
+++ b/block/blk-throttle.h
@@ -127,8 +127,8 @@ struct throtl_grp {
         * bytes/ios are waited already in previous configuration, and they will
         * be used to calculate wait time under new configuration.
         */
-       uint64_t carryover_bytes[2];
-       unsigned int carryover_ios[2];
+       long long carryover_bytes[2];
+       int carryover_ios[2];
 
        unsigned long last_check_time;