media: i2c: imx219: Move variables to inner scope
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 24 Sep 2023 15:33:09 +0000 (18:33 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 7 Oct 2023 08:55:47 +0000 (10:55 +0200)
The exposure_max, exposure_def and hblank variables are only used in an
inner scope in the imx219_set_pad_format() function. Move them to that
scope to keep them closer to their usage and improve readability.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/imx219.c

index 358a6d77d88cfaaf99e645e7d0af30b9be197166..8436880dcf7a8aa78ba240a5df8ee30cd7dc8c68 100644 (file)
@@ -815,7 +815,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
 {
        struct imx219 *imx219 = to_imx219(sd);
        const struct imx219_mode *mode;
-       int exposure_max, exposure_def, hblank;
        struct v4l2_mbus_framefmt *format;
        struct v4l2_rect *crop;
        unsigned int bin_h, bin_v;
@@ -844,6 +843,10 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
        crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2;
 
        if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
+               int exposure_max;
+               int exposure_def;
+               int hblank;
+
                /* Update limits and set FPS to default */
                __v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN,
                                         IMX219_VTS_MAX - mode->height, 1,