media: dvb-frontends: mb86a16.c: remove useless if/else
authorDaniel W. S. Almeida <dwlsalmeida@gmail.com>
Fri, 7 Aug 2020 08:35:40 +0000 (10:35 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 29 Aug 2020 06:02:46 +0000 (08:02 +0200)
Fix the following coccinelle report:

drivers/media/dvb-frontends/mb86a16.c:1455:6-8:
WARNING: possible condition with no effect (if == else)

Both branches are the same, so remove the if/else altogether.

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/mb86a16.c

index 3843181bba16be9d551fd3d7151230b7dd0582b4..2505f1e5794e78f719f119faf1260ba83799e79f 100644 (file)
@@ -1452,11 +1452,8 @@ static int mb86a16_set_fe(struct mb86a16_state *state)
                                                        wait_t = (786432 + state->srate / 2) / state->srate;
                                                else
                                                        wait_t = (1572864 + state->srate / 2) / state->srate;
-                                               if (state->srate < 5000)
-                                                       /* FIXME ! , should be a long wait ! */
-                                                       msleep_interruptible(wait_t);
-                                               else
-                                                       msleep_interruptible(wait_t);
+
+                                               msleep_interruptible(wait_t);
 
                                                if (sync_chk(state, &junk) == 0) {
                                                        iq_vt_set(state, 1);