drm/bridge: anx7625: Don't log an error when DSI host can't be found
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Mon, 15 Apr 2024 21:49:29 +0000 (17:49 -0400)
committerRobert Foss <rfoss@kernel.org>
Tue, 16 Apr 2024 13:18:48 +0000 (15:18 +0200)
Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.

Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-1-619a28148e5c@collabora.com
drivers/gpu/drm/bridge/analogix/anx7625.c

index 9d96d28d6fe8e1a32d26881c13c54d450754c30c..02bf450053076d338b091b5cfed34fb43453a3da 100644 (file)
@@ -2066,10 +2066,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx)
        };
 
        host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node);
-       if (!host) {
-               DRM_DEV_ERROR(dev, "fail to find dsi host.\n");
-               return -EPROBE_DEFER;
-       }
+       if (!host)
+               return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n");
 
        dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
        if (IS_ERR(dsi)) {