drm/bridge: ti-sn65dsi86: Propagate errors in .get_state() to the caller
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 2 Dec 2022 18:35:28 +0000 (19:35 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 6 Dec 2022 11:46:23 +0000 (12:46 +0100)
.get_state() can return an error indication. Make use of it to propagate
failing hardware accesses.

Acked-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20221130152148.2769768-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index 6826d2423ae9afa308054310c862ac48e3a5434e..9671071490d8a3a26738ee9dc758fea8a5e8f8b8 100644 (file)
@@ -1512,19 +1512,19 @@ static int ti_sn_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
 
        ret = regmap_read(pdata->regmap, SN_PWM_EN_INV_REG, &pwm_en_inv);
        if (ret)
-               return 0;
+               return ret;
 
        ret = ti_sn65dsi86_read_u16(pdata, SN_BACKLIGHT_SCALE_REG, &scale);
        if (ret)
-               return 0;
+               return ret;
 
        ret = ti_sn65dsi86_read_u16(pdata, SN_BACKLIGHT_REG, &backlight);
        if (ret)
-               return 0;
+               return ret;
 
        ret = regmap_read(pdata->regmap, SN_PWM_PRE_DIV_REG, &pre_div);
        if (ret)
-               return 0;
+               return ret;
 
        state->enabled = FIELD_GET(SN_PWM_EN_MASK, pwm_en_inv);
        if (FIELD_GET(SN_PWM_INV_MASK, pwm_en_inv))