scsi: ufs: core: Remove redundant call in ufshcd_add_command_trace()
authorBean Huo <beanhuo@micron.com>
Mon, 2 Aug 2021 18:08:03 +0000 (20:08 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 6 Aug 2021 03:21:08 +0000 (23:21 -0400)
ufshcd_add_cmd_upiu_trace() will be called later anyway. Simplify code by
moving if-statement.

Link: https://lore.kernel.org/r/20210802180803.100033-1-huobean@gmail.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 47a5085f16a9535a63e9aed1c85a3bf930b48582..d96409202819a79ed475264143c27df69e20ca94 100644 (file)
@@ -369,14 +369,11 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
        if (!cmd)
                return;
 
-       if (!trace_ufshcd_command_enabled()) {
-               /* trace UPIU W/O tracing command */
-               ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
-               return;
-       }
-
        /* trace UPIU also */
        ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
+       if (!trace_ufshcd_command_enabled())
+               return;
+
        opcode = cmd->cmnd[0];
        lba = scsi_get_lba(cmd);