NFSv4.1: Don't decrease the value of seq_nr_highest_sent
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 12 Jul 2022 13:16:04 +0000 (09:16 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 12 Jul 2022 13:53:45 +0000 (09:53 -0400)
When we're trying to figure out what the server may or may not have seen
in terms of request numbers, do not assume that requests with a larger
number were missed, just because we saw a reply to a request with a
smaller number.

Fixes: 3453d5708b33 ("NFSv4.1: Avoid false retries when RPC calls are interrupted")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4proc.c

index bb0e84a46d61a38848e0c94c36a9e602b5bb6e19..628471d069473732a6c1085eb7d07e07450b97c6 100644 (file)
@@ -784,10 +784,9 @@ static void nfs4_slot_sequence_record_sent(struct nfs4_slot *slot,
        if ((s32)(seqnr - slot->seq_nr_highest_sent) > 0)
                slot->seq_nr_highest_sent = seqnr;
 }
-static void nfs4_slot_sequence_acked(struct nfs4_slot *slot,
-               u32 seqnr)
+static void nfs4_slot_sequence_acked(struct nfs4_slot *slot, u32 seqnr)
 {
-       slot->seq_nr_highest_sent = seqnr;
+       nfs4_slot_sequence_record_sent(slot, seqnr);
        slot->seq_nr_last_acked = seqnr;
 }