phy: phy-twl4030-usb: use DEVICE_ATTR_RO macro
authorYueHaibing <yuehaibing@huawei.com>
Thu, 20 May 2021 13:51:32 +0000 (21:51 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 31 May 2021 08:38:58 +0000 (14:08 +0530)
Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20210520135132.37628-1-yuehaibing@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-twl4030-usb.c

index 812e5409d35958e75cf06a19efc1eec71124739a..5771e2486a3bd4e094d6c13081fcc626ec54619e 100644 (file)
@@ -544,8 +544,8 @@ static int twl4030_usb_ldo_init(struct twl4030_usb *twl)
        return 0;
 }
 
-static ssize_t twl4030_usb_vbus_show(struct device *dev,
-               struct device_attribute *attr, char *buf)
+static ssize_t vbus_show(struct device *dev,
+                        struct device_attribute *attr, char *buf)
 {
        struct twl4030_usb *twl = dev_get_drvdata(dev);
        int ret = -EINVAL;
@@ -557,7 +557,7 @@ static ssize_t twl4030_usb_vbus_show(struct device *dev,
 
        return ret;
 }
-static DEVICE_ATTR(vbus, 0444, twl4030_usb_vbus_show, NULL);
+static DEVICE_ATTR_RO(vbus);
 
 static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
 {