net: dsa: qca8k: Initialize the switch with correct number of ports
authorMichal Vokáč <michal.vokac@ysoft.com>
Thu, 24 Oct 2019 13:46:58 +0000 (15:46 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Oct 2019 20:39:31 +0000 (13:39 -0700)
Since commit 0394a63acfe2 ("net: dsa: enable and disable all ports")
the dsa core disables all unused ports of a switch. In this case
disabling ports with numbers higher than QCA8K_NUM_PORTS causes that
some switch registers are overwritten with incorrect content.

To fix this, initialize the dsa_switch->num_ports with correct number
of ports.

Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca8k.c

index 7e742cd491e865921ffa80380e24017d28f087ae..36c6ed98f8e7cd9d330fe462bbe01606192632dd 100644 (file)
@@ -1083,7 +1083,7 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
                return -ENOMEM;
 
        priv->ds->dev = &mdiodev->dev;
-       priv->ds->num_ports = DSA_MAX_PORTS;
+       priv->ds->num_ports = QCA8K_NUM_PORTS;
        priv->ds->priv = priv;
        priv->ops = qca8k_switch_ops;
        priv->ds->ops = &priv->ops;