drm/amd/display: Turn global functions into static functions
authorMaíra Canal <maira.canal@usp.br>
Tue, 22 Feb 2022 13:17:01 +0000 (10:17 -0300)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 23 Feb 2022 19:03:20 +0000 (14:03 -0500)
Turn previously global functions into static functions to avoid
-Wmissing-prototype warnings, such as:

drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:20:
warning: no previous prototype for function 'to_dal_irq_source_dcn30'
[-Wmissing-prototypes]
enum dc_irq_source to_dal_irq_source_dcn30(
                   ^
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:1:
note: declare 'static' if the function is not intended to be used outside
of this translation unit
enum dc_irq_source to_dal_irq_source_dcn30(
^
static
1 warning generated.

drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:488:6:
warning: no previous prototype for function
'dcn316_clk_mgr_helper_populate_bw_params' [-Wmissing-prototypes]
void dcn316_clk_mgr_helper_populate_bw_params(
     ^
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:488:1:
note: declare 'static' if the function is not intended to be used outside
of this translation unit
void dcn316_clk_mgr_helper_populate_bw_params(
^
static
1 warning generated.

v2: drop is_timing_changed hunk (Alex)

Signed-off-by: Maíra Canal <maira.canal@usp.br>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c
drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c
drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c

index d73ec30c5bb7dc45ccedce48f913f710cfadef3f..6b2e46ed61848bca704e33f6e68fae69dc77fcaf 100644 (file)
@@ -6387,7 +6387,7 @@ static bool is_freesync_video_mode(const struct drm_display_mode *mode,
                return true;
 }
 
-struct dc_stream_state *
+static struct dc_stream_state *
 create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
                       const struct drm_display_mode *drm_mode,
                       const struct dm_connector_state *dm_state,
@@ -10214,7 +10214,7 @@ static void set_freesync_fixed_config(struct dm_crtc_state *dm_new_crtc_state) {
        dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz = res;
 }
 
-int dm_update_crtc_state(struct amdgpu_display_manager *dm,
+static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
                         struct drm_atomic_state *state,
                         struct drm_crtc *crtc,
                         struct drm_crtc_state *old_crtc_state,
index 1feb0602066671ff9773adc89b87ecf6def84544..740435ae3997db224b10736b4cb0d046972041dc 100644 (file)
@@ -213,7 +213,7 @@ static bool validate_dsc_caps_on_connector(struct amdgpu_dm_connector *aconnecto
        return true;
 }
 
-bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnector)
+static bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnector)
 {
        union dp_downstream_port_present ds_port_present;
 
index 06bab24d8e270c36c4f4673cca92b85052feb33e..450eaead4f20c9acb24ddf9024c8ebcb08e3e645 100644 (file)
@@ -101,7 +101,8 @@ static uint32_t rv1_smu_wait_for_response(struct clk_mgr_internal *clk_mgr, unsi
        return res_val;
 }
 
-int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, unsigned int msg_id, unsigned int param)
+static int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
+               unsigned int msg_id, unsigned int param)
 {
        uint32_t result;
 
index ffd3d5cb987106800fd5e5e2ea56a90de89afca9..02a59adff90d8d8b80909aee949ab4c5cc398f55 100644 (file)
@@ -485,7 +485,7 @@ static unsigned int find_clk_for_voltage(
        return clock;
 }
 
-void dcn316_clk_mgr_helper_populate_bw_params(
+static void dcn316_clk_mgr_helper_populate_bw_params(
                struct clk_mgr_internal *clk_mgr,
                struct integrated_info *bios_info,
                const DpmClocks_316_t *clock_table)
index fd6497fd2dc5225da41c2aa5fc5a78eaed932913..128614dff1089c77d339989f083cf3c564163f23 100644 (file)
@@ -111,7 +111,7 @@ static uint32_t dcn316_smu_wait_for_response(struct clk_mgr_internal *clk_mgr, u
        return res_val;
 }
 
-int dcn316_smu_send_msg_with_param(
+static int dcn316_smu_send_msg_with_param(
                struct clk_mgr_internal *clk_mgr,
                unsigned int msg_id, unsigned int param)
 {
index c4b067d0189565f8801a8c3d35be2529fb07e9b0..93c31111500bb7b6dbdaa337e30084f431fccb41 100644 (file)
@@ -40,7 +40,7 @@
 
 #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h"
 
-enum dc_irq_source to_dal_irq_source_dcn20(
+static enum dc_irq_source to_dal_irq_source_dcn20(
                struct irq_service *irq_service,
                uint32_t src_id,
                uint32_t ext_id)
index 0b68c08fac3f0877c4c6f7b3da5d081bc0ac6629..ac0c6a62d17b6684cdb8bd3a76521bdbb18cc087 100644 (file)
@@ -47,7 +47,7 @@
 
 #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h"
 
-enum dc_irq_source to_dal_irq_source_dcn30(
+static enum dc_irq_source to_dal_irq_source_dcn30(
                struct irq_service *irq_service,
                uint32_t src_id,
                uint32_t ext_id)