hw/qdev-clock: Uninline qdev_connect_clock_in()
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Fri, 28 Aug 2020 09:02:46 +0000 (10:02 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 28 Aug 2020 09:02:46 +0000 (10:02 +0100)
We want to assert the device is not realized. To avoid overloading
this header including "hw/qdev-core.h", uninline the function first.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200803105647.22223-4-f4bug@amsat.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/core/qdev-clock.c
include/hw/qdev-clock.h

index 5cc1e82e510405957e68b169fd5140bbc91c7143..f139b68b88183d5d911103ac474de0cf5820ef2e 100644 (file)
@@ -183,3 +183,8 @@ Clock *qdev_alias_clock(DeviceState *dev, const char *name,
 
     return ncl->clock;
 }
+
+void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source)
+{
+    clock_set_source(qdev_get_clock_in(dev, name), source);
+}
index a340f65ff9091d2f70772dda9bd73e7fbf959c8b..a897f7c9d0f35685a09d4d278847891f7dfc8ddd 100644 (file)
@@ -71,11 +71,7 @@ Clock *qdev_get_clock_out(DeviceState *dev, const char *name);
  * Set the source clock of input clock @name of device @dev to @source.
  * @source period update will be propagated to @name clock.
  */
-static inline void qdev_connect_clock_in(DeviceState *dev, const char *name,
-                                         Clock *source)
-{
-    clock_set_source(qdev_get_clock_in(dev, name), source);
-}
+void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source);
 
 /**
  * qdev_alias_clock: