arm64: dts: qcom: sc7180: Enable cros-ec-spi as wake source
authorMark Hasemeyer <markhas@chromium.org>
Tue, 2 Jan 2024 21:07:38 +0000 (14:07 -0700)
committerBjorn Andersson <andersson@kernel.org>
Wed, 14 Feb 2024 05:37:17 +0000 (23:37 -0600)
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.

Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.

Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
Link: https://lore.kernel.org/r/20240102140734.v4.14.I2ee94aede9e25932f656c2bdb832be3199fa1291@changeid
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

index 46aaeba286047a074fe79db418254a2e382591f3..f3a6da8b28901907d0fbc533b2d63c498ecb5afc 100644 (file)
@@ -649,6 +649,7 @@ ap_ec_spi: &spi6 {
                pinctrl-names = "default";
                pinctrl-0 = <&ap_ec_int_l>;
                spi-max-frequency = <3000000>;
+               wakeup-source;
 
                cros_ec_pwm: pwm {
                        compatible = "google,cros-ec-pwm";