drm/imagination: Fix ERR_PTR test on pointer to pointer.

drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context()
  error: 'vm_ctx->mmu_ctx' dereferencing possible ERR_PTR()

612         vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev);
613         err = PTR_ERR_OR_ZERO(&vm_ctx->mmu_ctx);
                                      ^
The address is never an error pointer so this will always return 0.
Remove the ampersand.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231213144431.94956-1-donald.robson@imgtec.com

diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
index 82690cee978c407a68ef7cda75b60c357084e631..598d79d7c7d08d96674539b917ecc595c5f4a9cc 100644 (file)
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -568,7 +568,7 @@ pvr_vm_create_context(struct pvr_device *pvr_dev, bool is_userspace_context)
                       0, 1ULL << device_addr_bits, 0, 0, &pvr_vm_gpuva_ops);
 
        vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev);
-       err = PTR_ERR_OR_ZERO(&vm_ctx->mmu_ctx);
+       err = PTR_ERR_OR_ZERO(vm_ctx->mmu_ctx);
        if (err) {
                vm_ctx->mmu_ctx = NULL;
                goto err_put_ctx;