vp_vdpa: Fix return value check vp_vdpa_request_irq

In the vp_vdpa_set_status function, when setting the device status to
VIRTIO_CONFIG_S_DRIVER_OK, the vp_vdpa_request_irq function may fail.
In such cases, the device status should not be set to DRIVER_OK. Add
exception printing to remind the user.

Signed-off-by: Yuxue Liu <yuxue.liu@jaguarmicro.com>
Message-Id: <20240325105448.235-1-gavin.liu@jaguarmicro.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
index df5f4a3bccb57ab63ae14be32c3a30692eeb8ac0..4caca0517cad4bb1eee505a43b8261025be2ebee 100644 (file)
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -216,7 +216,10 @@ static void vp_vdpa_set_status(struct vdpa_device *vdpa, u8 status)
 
        if (status & VIRTIO_CONFIG_S_DRIVER_OK &&
            !(s & VIRTIO_CONFIG_S_DRIVER_OK)) {
-               vp_vdpa_request_irq(vp_vdpa);
+               if (vp_vdpa_request_irq(vp_vdpa)) {
+                       WARN_ON(1);
+                       return;
+               }
        }
 
        vp_modern_set_status(mdev, status);