backlight: ktz8866: Correct the check for of_property_read_u32
authorJianhua Lu <lujianhua000@gmail.com>
Mon, 29 Jan 2024 12:28:29 +0000 (20:28 +0800)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 09:03:28 +0000 (09:03 +0000)
of_property_read_u32 returns 0 when success, so reverse the
return value to get the true value.

Fixes: f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 backlight")
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240129122829.16248-1-lujianhua000@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/ktz8866.c

index 9c980f2571ee3594cbefda4e7a13950210d8669d..014877b5a9848f27c71e5003299669d39fd6da8e 100644 (file)
@@ -97,20 +97,20 @@ static void ktz8866_init(struct ktz8866 *ktz)
 {
        unsigned int val = 0;
 
-       if (of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val))
+       if (!of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val))
                ktz8866_write(ktz, BL_EN, BIT(val) - 1);
        else
                /* Enable all 6 current sinks if the number of current sinks isn't specified. */
                ktz8866_write(ktz, BL_EN, BIT(6) - 1);
 
-       if (of_property_read_u32(ktz->client->dev.of_node, "kinetic,current-ramp-delay-ms", &val)) {
+       if (!of_property_read_u32(ktz->client->dev.of_node, "kinetic,current-ramp-delay-ms", &val)) {
                if (val <= 128)
                        ktz8866_write(ktz, BL_CFG2, BIT(7) | (ilog2(val) << 3) | PWM_HYST);
                else
                        ktz8866_write(ktz, BL_CFG2, BIT(7) | ((5 + val / 64) << 3) | PWM_HYST);
        }
 
-       if (of_property_read_u32(ktz->client->dev.of_node, "kinetic,led-enable-ramp-delay-ms", &val)) {
+       if (!of_property_read_u32(ktz->client->dev.of_node, "kinetic,led-enable-ramp-delay-ms", &val)) {
                if (val == 0)
                        ktz8866_write(ktz, BL_DIMMING, 0);
                else {