soundwire: bus: add better dev_dbg to track complete() calls
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 26 Jan 2021 08:54:02 +0000 (16:54 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 1 Feb 2021 10:40:40 +0000 (16:10 +0530)
Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210126085402.4264-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/bus.c

index 6e1c988f3845e4576e23fb63cb504e453c5fb3d4..82df088c9333897e77c3ee9b58583a797afff772 100644 (file)
@@ -784,7 +784,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
 
        if (status == SDW_SLAVE_UNATTACHED) {
                dev_dbg(&slave->dev,
-                       "%s: initializing completion for Slave %d\n",
+                       "%s: initializing enumeration and init completion for Slave %d\n",
                        __func__, slave->dev_num);
 
                init_completion(&slave->enumeration_complete);
@@ -793,7 +793,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
        } else if ((status == SDW_SLAVE_ATTACHED) &&
                   (slave->status == SDW_SLAVE_UNATTACHED)) {
                dev_dbg(&slave->dev,
-                       "%s: signaling completion for Slave %d\n",
+                       "%s: signaling enumeration completion for Slave %d\n",
                        __func__, slave->dev_num);
 
                complete(&slave->enumeration_complete);
@@ -1758,8 +1758,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
                if (ret)
                        dev_err(slave->bus->dev,
                                "Update Slave status failed:%d\n", ret);
-               if (attached_initializing)
+               if (attached_initializing) {
+                       dev_dbg(&slave->dev,
+                               "%s: signaling initialization completion for Slave %d\n",
+                               __func__, slave->dev_num);
+
                        complete(&slave->initialization_complete);
+               }
        }
 
        return ret;