iomap: directly use logical block size
authorKeith Busch <kbusch@kernel.org>
Mon, 14 Nov 2022 18:35:32 +0000 (10:35 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Mon, 14 Nov 2022 18:35:32 +0000 (10:35 -0800)
Don't transform the logical block size to a bit shift only to shift it
back to the original block size. Just use the size.

Cc: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/iomap/direct-io.c

index 4eb559a16c9ed33e3a1f5102409bddc95491d048..9804714b17518e2716642e03fc0c8a708d722490 100644 (file)
@@ -240,7 +240,6 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
 {
        const struct iomap *iomap = &iter->iomap;
        struct inode *inode = iter->inode;
-       unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
        unsigned int fs_block_size = i_blocksize(inode), pad;
        loff_t length = iomap_length(iter);
        loff_t pos = iter->pos;
@@ -252,7 +251,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
        size_t copied = 0;
        size_t orig_count;
 
-       if ((pos | length) & ((1 << blkbits) - 1) ||
+       if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1) ||
            !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
                return -EINVAL;