drm/i915: Don't hide function calls with side effects
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 14 Feb 2023 13:47:38 +0000 (15:47 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Feb 2023 10:01:45 +0000 (12:01 +0200)
Hiding a function call with side effects inside the
variable declaration block is a bit rude. Make it
stand out more.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230214134739.25077-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_backlight.c

index cb1e4423decb2c00f07884c4cc4e7e77d0f1a0bf..ba0280131a5badc640e520b1964e1511124c70fd 100644 (file)
@@ -1614,8 +1614,9 @@ static void intel_pwm_disable_backlight(const struct drm_connector_state *conn_s
 static int intel_pwm_setup_backlight(struct intel_connector *connector, enum pipe pipe)
 {
        struct intel_panel *panel = &connector->panel;
-       int ret = panel->backlight.pwm_funcs->setup(connector, pipe);
+       int ret;
 
+       ret = panel->backlight.pwm_funcs->setup(connector, pipe);
        if (ret < 0)
                return ret;