media: i2c: ov7740: Drop check for reentrant .s_stream()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 14 Sep 2023 18:16:34 +0000 (21:16 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 27 Sep 2023 07:39:59 +0000 (09:39 +0200)
The subdev .s_stream() operation shall not be called to start streaming
on an already started subdev, or stop streaming on a stopped subdev.
Remove the check that guards against that condition.

The streaming field of the driver's private structure is now unused,
drop it as well.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/ov7740.c

index 78d04ce68971ad596c88f23e8eff424ca8bdf02d..356a45e65b81bf1bb666dae69a85e4789b3b56e6 100644 (file)
@@ -118,7 +118,6 @@ struct ov7740 {
        struct v4l2_ctrl *contrast;
 
        struct mutex mutex;     /* To serialize asynchronus callbacks */
-       bool streaming;         /* Streaming on/off */
 
        struct gpio_desc *resetb_gpio;
        struct gpio_desc *pwdn_gpio;
@@ -616,10 +615,6 @@ static int ov7740_set_stream(struct v4l2_subdev *sd, int enable)
        int ret = 0;
 
        mutex_lock(&ov7740->mutex);
-       if (ov7740->streaming == enable) {
-               mutex_unlock(&ov7740->mutex);
-               return 0;
-       }
 
        if (enable) {
                ret = pm_runtime_resume_and_get(&client->dev);
@@ -633,8 +628,6 @@ static int ov7740_set_stream(struct v4l2_subdev *sd, int enable)
                pm_runtime_put(&client->dev);
        }
 
-       ov7740->streaming = enable;
-
        mutex_unlock(&ov7740->mutex);
        return ret;