media: netup_unidvb: Use min macro
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:04:54 +0000 (16:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:12:43 +0000 (11:12 +0100)
Simplify the code.

Found by cocci:
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c:138:26-27: WARNING opportunity for min()

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-15-3c4865f5a4b0@chromium.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c

index 46676f2c89c72766844f26efbf8543e731122790..1c885d620b75ede528e5d13c61f7639e794b913f 100644 (file)
@@ -135,7 +135,7 @@ static void netup_i2c_fifo_tx(struct netup_i2c *i2c)
                (readw(&i2c->regs->tx_fifo.stat_ctrl) & 0x3f);
        u32 msg_length = i2c->msg->len - i2c->xmit_size;
 
-       msg_length = (msg_length < fifo_space ? msg_length : fifo_space);
+       msg_length = min(msg_length, fifo_space);
        while (msg_length--) {
                data = i2c->msg->buf[i2c->xmit_size++];
                writeb(data, &i2c->regs->tx_fifo.data8);