kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbol_descriptor()

~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function:

  3d7e33825d87: ("jprobes: make jprobes a little safer for users")

But this is just open-coded dereference_symbol_descriptor() in essence, and
its obscure nature was causing bugs.

Just use the real thing and remove arch_deref_entry_point().

Link: https://lkml.kernel.org/r/163163043630.489837.7924988885652708696.stgit@devnote2
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c
index d4048518a1d7d9655b2f873e831a42185371836c..0f8573bbf520e94fbe50cd4a0f38249d93e8aa4f 100644 (file)
--- a/arch/ia64/kernel/kprobes.c
+++ b/arch/ia64/kernel/kprobes.c
@@ -891,11 +891,6 @@ int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
        return ret;
 }
 
-unsigned long arch_deref_entry_point(void *entry)
-{
-       return ((struct fnptr *)entry)->ip;
-}
-
 static struct kprobe trampoline_p = {
        .pre_handler = trampoline_probe_handler
 };

diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c
index 7a7cd6bda53ead1c783f778bde2bc7cbb502a4ad..d422e297978be89fdd2b97b450f051d4eaf81084 100644 (file)
--- a/arch/powerpc/kernel/kprobes.c
+++ b/arch/powerpc/kernel/kprobes.c
@@ -542,17 +542,6 @@ int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
 }
 NOKPROBE_SYMBOL(kprobe_fault_handler);
 
-unsigned long arch_deref_entry_point(void *entry)
-{
-#ifdef PPC64_ELF_ABI_v1
-       if (!kernel_text_address((unsigned long)entry))
-               return ppc_global_function_entry(entry);
-       else
-#endif
-               return (unsigned long)entry;
-}
-NOKPROBE_SYMBOL(arch_deref_entry_point);
-
 static struct kprobe trampoline_p = {
        .addr = (kprobe_opcode_t *) &kretprobe_trampoline,
        .pre_handler = trampoline_probe_handler

diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index 0ba3f9e316d4c73297e396d8dcf42d1d44a094e7..2ed61fcbc89c67e21a48d49037ebddf775c21316 100644 (file)
--- a/include/linux/kprobes.h
+++ b/include/linux/kprobes.h
@@ -381,7 +381,6 @@ int register_kprobe(struct kprobe *p);
 void unregister_kprobe(struct kprobe *p);
 int register_kprobes(struct kprobe **kps, int num);
 void unregister_kprobes(struct kprobe **kps, int num);
-unsigned long arch_deref_entry_point(void *);
 
 int register_kretprobe(struct kretprobe *rp);
 void unregister_kretprobe(struct kretprobe *rp);

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 8021bccb777078702c63b503f61bea1335f1c979..550042d9a6ef46cd47db2bc0728a7b2846f2c8fe 100644 (file)
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1861,11 +1861,6 @@ static struct notifier_block kprobe_exceptions_nb = {
        .priority = 0x7fffffff /* we need to be notified first */
 };
 
-unsigned long __weak arch_deref_entry_point(void *entry)
-{
-       return (unsigned long)entry;
-}
-
 #ifdef CONFIG_KRETPROBES
 
 unsigned long __kretprobe_trampoline_handler(struct pt_regs *regs,
@@ -2327,7 +2322,7 @@ static int __init populate_kprobe_blacklist(unsigned long *start,
        int ret;
 
        for (iter = start; iter < end; iter++) {
-               entry = arch_deref_entry_point((void *)*iter);
+               entry = (unsigned long)dereference_symbol_descriptor((void *)*iter);
                ret = kprobe_add_ksym_blacklist(entry);
                if (ret == -EINVAL)
                        continue;

diff --git a/lib/error-inject.c b/lib/error-inject.c
index c73651b15b768855fabf71381effdf2bef0f9396..2ff5ef689d7271c22c157644218d2a544d1b4864 100644 (file)
--- a/lib/error-inject.c
+++ b/lib/error-inject.c
@@ -8,6 +8,7 @@
 #include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/slab.h>
+#include <asm/sections.h>
 
 /* Whitelist of symbols that can be overridden for error injection. */
 static LIST_HEAD(error_injection_list);
@@ -64,7 +65,7 @@ static void populate_error_injection_list(struct error_injection_entry *start,
 
        mutex_lock(&ei_mutex);
        for (iter = start; iter < end; iter++) {
-               entry = arch_deref_entry_point((void *)iter->addr);
+               entry = (unsigned long)dereference_symbol_descriptor((void *)iter->addr);
 
                if (!kernel_text_address(entry) ||
                    !kallsyms_lookup_size_offset(entry, &size, &offset)) {