NFS: Don't use RPC_TASK_CRED_NOREF with delegreturn
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 11 May 2020 14:42:04 +0000 (10:42 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 11 May 2020 18:06:51 +0000 (14:06 -0400)
We are not guaranteed that the credential will remain pinned.

Fixes: 612965072020 ("NFSv4: Avoid referencing the cred unnecessarily during NFSv4 I/O")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4proc.c

index a0c1e653a935875823cb255f80db3de20004ab07..9056f3dd380e54e1a6d9c97aeba2c91748ba7ed0 100644 (file)
@@ -6347,7 +6347,7 @@ static int _nfs4_proc_delegreturn(struct inode *inode, const struct cred *cred,
                .rpc_client = server->client,
                .rpc_message = &msg,
                .callback_ops = &nfs4_delegreturn_ops,
-               .flags = RPC_TASK_ASYNC | RPC_TASK_CRED_NOREF | RPC_TASK_TIMEOUT,
+               .flags = RPC_TASK_ASYNC | RPC_TASK_TIMEOUT,
        };
        int status = 0;