tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check
authorMarkus Armbruster <armbru@redhat.com>
Sat, 3 Feb 2024 08:02:26 +0000 (09:02 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 14 Feb 2024 06:45:08 +0000 (07:45 +0100)
qemu_socket() and make_udp_socket() return a file descriptor on
success, -1 on failure.  The check misinterprets 0 as failure.  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240203080228.2766159-3-armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
tests/unit/test-char.c

index 2aea49c3b647a1bfcb0d7ff1a1386d1f2ecbaa5f..f273ce522612b50861b131ba7ac0b2c81aca17cf 100644 (file)
@@ -556,7 +556,7 @@ static int make_udp_socket(int *port)
     socklen_t alen = sizeof(addr);
     int ret, sock = qemu_socket(PF_INET, SOCK_DGRAM, 0);
 
-    g_assert_cmpint(sock, >, 0);
+    g_assert_cmpint(sock, >=, 0);
     addr.sin_family = AF_INET ;
     addr.sin_addr.s_addr = htonl(INADDR_ANY);
     addr.sin_port = 0;
@@ -1407,7 +1407,7 @@ static void char_hotswap_test(void)
 
     int port;
     int sock = make_udp_socket(&port);
-    g_assert_cmpint(sock, >, 0);
+    g_assert_cmpint(sock, >=, 0);
 
     chr_args = g_strdup_printf("udp:127.0.0.1:%d", port);