rcu/nocb: Check rdp_gp->nocb_timer in __call_rcu_nocb_wake()
authorZqiang <qiang.zhang1211@gmail.com>
Wed, 17 Jan 2024 10:26:16 +0000 (18:26 +0800)
committerBoqun Feng <boqun.feng@gmail.com>
Wed, 14 Feb 2024 15:50:45 +0000 (07:50 -0800)
Currently, only rdp_gp->nocb_timer is used, for nocb_timer of
no-rdp_gp structure, the timer_pending() is always return false,
this commit therefore need to check rdp_gp->nocb_timer in
__call_rcu_nocb_wake().

Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
kernel/rcu/tree_nocb.h

index ffa69a5e18f4c23a44cbcd80434b4712a3c291f7..f124d4d45ce641ac84369bea08f91a5f8ca6854e 100644 (file)
@@ -564,6 +564,7 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone,
        long lazy_len;
        long len;
        struct task_struct *t;
+       struct rcu_data *rdp_gp = rdp->nocb_gp_rdp;
 
        // If we are being polled or there is no kthread, just leave.
        t = READ_ONCE(rdp->nocb_gp_kthread);
@@ -608,7 +609,7 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone,
                smp_mb(); /* Enqueue before timer_pending(). */
                if ((rdp->nocb_cb_sleep ||
                     !rcu_segcblist_ready_cbs(&rdp->cblist)) &&
-                   !timer_pending(&rdp->nocb_timer)) {
+                   !timer_pending(&rdp_gp->nocb_timer)) {
                        rcu_nocb_unlock(rdp);
                        wake_nocb_gp_defer(rdp, RCU_NOCB_WAKE_FORCE,
                                           TPS("WakeOvfIsDeferred"));