ceph: decoding error in ceph_update_snap_realm should return -EIO

Currently ceph_update_snap_realm returns -EINVAL when it hits a decoding
error, which is the wrong error code. -EINVAL implies that the user gave
us a bogus argument to a syscall or something similar. -EIO is more
descriptive when we hit a decoding error.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
index 44b380a53727a7d970668afaecec2ed1882ad4e0..2a63fb37778b30b74431ed154c3a1e450c322a15 100644 (file)
--- a/fs/ceph/snap.c
+++ b/fs/ceph/snap.c
@@ -791,7 +791,7 @@ more:
        return 0;
 
 bad:
-       err = -EINVAL;
+       err = -EIO;
 fail:
        if (realm && !IS_ERR(realm))
                ceph_put_snap_realm(mdsc, realm);