modules: Fix potential infinite loop in module collection

Fixes #12407

diff --git a/modules/collect.go b/modules/collect.go
index e7d5dbe292c92d3a984a7b23d5a7713819f6e29a..dff71924be38356a56a0953a09392344cae83a1d 100644 (file)
--- a/modules/collect.go
+++ b/modules/collect.go
@@ -261,7 +261,10 @@ func (c *collector) add(owner *moduleAdapter, moduleImport Import) (*moduleAdapt
                                        // This will select the latest release-version (not beta etc.).
                                        versionQuery = "upgrade"
                                }
-                               if err := c.Get(fmt.Sprintf("%s@%s", modulePath, versionQuery)); err != nil {
+
+                               // Note that we cannot use c.Get for this, as that may
+                               // trigger a new module collection and potentially create a infinite loop.
+                               if err := c.get(fmt.Sprintf("%s@%s", modulePath, versionQuery)); err != nil {
                                        return nil, err
                                }
                                if err := c.loadModules(); err != nil {