clk: imx: avoid memory leak
authorPeng Fan <peng.fan@nxp.com>
Wed, 4 Jan 2023 11:00:29 +0000 (19:00 +0800)
committerAbel Vesa <abel.vesa@linaro.org>
Sun, 29 Jan 2023 18:29:17 +0000 (20:29 +0200)
In case imx_register_uart_clocks return early, the imx_uart_clocks
memory will be no freed. So execute kfree always to avoid memory leak.

Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230104110032.1220721-2-peng.fan@oss.nxp.com
drivers/clk/imx/clk.c

index b636cc099d96525a1f3ef29e8ddee9d92bb46103..5b73a477f11fd13edba8cad4b25f70c50f3a7262 100644 (file)
@@ -205,9 +205,10 @@ static int __init imx_clk_disable_uart(void)
                        clk_disable_unprepare(imx_uart_clocks[i]);
                        clk_put(imx_uart_clocks[i]);
                }
-               kfree(imx_uart_clocks);
        }
 
+       kfree(imx_uart_clocks);
+
        return 0;
 }
 late_initcall_sync(imx_clk_disable_uart);