coresight-tpdm: Remove the unnecessary lock
authorTao Zhang <quic_taozha@quicinc.com>
Thu, 28 Sep 2023 06:29:34 +0000 (14:29 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 16 Nov 2023 11:35:15 +0000 (11:35 +0000)
Remove the unnecessary lock "CS_{UN,}LOCK" in TPDM driver. This
lock is only needed while writing the data to Coresight registers.

Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/1695882586-10306-2-git-send-email-quic_taozha@quicinc.com
drivers/hwtracing/coresight/coresight-tpdm.c

index f4854af0431e11069ec521311fd1225e53490174..b6456120b76a1a4f90a8d9a4a25a63d15c768102 100644 (file)
@@ -114,11 +114,9 @@ static void tpdm_init_default_data(struct tpdm_drvdata *drvdata)
 {
        u32 pidr;
 
-       CS_UNLOCK(drvdata->base);
        /*  Get the datasets present on the TPDM. */
        pidr = readl_relaxed(drvdata->base + CORESIGHT_PERIPHIDR0);
        drvdata->datasets |= pidr & GENMASK(TPDM_DATASETS - 1, 0);
-       CS_LOCK(drvdata->base);
 }
 
 /*