power: supply: ab8500_charger: Fix inconsistent IS_ERR and PTR_ERR
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 21 Oct 2019 17:49:37 +0000 (12:49 -0500)
committerSebastian Reichel <sre@kernel.org>
Sun, 27 Oct 2019 21:33:07 +0000 (22:33 +0100)
Fix inconsistent IS_ERR and PTR_ERR in ab8500_charger_probe().

The proper pointer to be passed as argument is di->adc_main_charger_c

This bug was detected with the help of Coccinelle.

Fixes: 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ab8500_charger.c

index ff2bb4411a223424335379a01f10aeb3ee11711c..8a0f9d7696907f3dc2e8b438472d65305a4ee789 100644 (file)
@@ -3393,7 +3393,7 @@ static int ab8500_charger_probe(struct platform_device *pdev)
                if (PTR_ERR(di->adc_main_charger_c) == -ENODEV)
                        return -EPROBE_DEFER;
                dev_err(&pdev->dev, "failed to get ADC main charger current\n");
-               return PTR_ERR(di->adc_main_charger_v);
+               return PTR_ERR(di->adc_main_charger_c);
        }
        di->adc_vbus_v = devm_iio_channel_get(&pdev->dev, "vbus_v");
        if (IS_ERR(di->adc_vbus_v)) {