iio:addac:ad74413r: Fix uninitialized ret in a path that won't be hit.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 20 Dec 2021 16:47:26 +0000 (16:47 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 21 Dec 2021 15:10:10 +0000 (15:10 +0000)
I don't believe it's possible to hit this, because we drop
out of __iio_update_buffers() earlier in the event of an empty
list.  However, that is not visible to the compiler so lets
return an error if we do hit the loop with an empty bitmask.

Fixes: 5d97d9e9a703 ("iio: addac: ad74413r: fix off by one in ad74413r_parse_channel_config()")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>
Link: https://lore.kernel.org/r/20211220164726.3136307-1-jic23@kernel.org
drivers/iio/addac/ad74413r.c

index 289d254943e166d860ec9b10d900bfcf5d399809..5271073bb74e773dcef171bafc8fc504c6b1120e 100644 (file)
@@ -843,7 +843,7 @@ static int ad74413r_update_scan_mode(struct iio_dev *indio_dev,
        u8 *rx_buf = &st->adc_samples_buf.rx_buf[-1 * AD74413R_FRAME_SIZE];
        u8 *tx_buf = st->adc_samples_tx_buf;
        unsigned int channel;
-       int ret;
+       int ret = -EINVAL;
 
        mutex_lock(&st->lock);