serial: 8250: 8250_omap: Fix throttle to call stop_rx()
authorVignesh Raghavendra <vigneshr@ti.com>
Thu, 19 Mar 2020 10:32:30 +0000 (16:02 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Mar 2020 11:25:09 +0000 (12:25 +0100)
Call stop_rx() to halt reception when throttle is requested. Update
unthrottle callback to restart reception.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Link: https://lore.kernel.org/r/20200319103230.16867-3-vigneshr@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index dd69226ce9188522685523dd8be269b5224bc0d6..b0e70390bc55d436364e2f77c69bbbe8b76cc67a 100644 (file)
@@ -699,14 +699,12 @@ static void omap_8250_shutdown(struct uart_port *port)
 static void omap_8250_throttle(struct uart_port *port)
 {
        struct omap8250_priv *priv = port->private_data;
-       struct uart_8250_port *up = up_to_u8250p(port);
        unsigned long flags;
 
        pm_runtime_get_sync(port->dev);
 
        spin_lock_irqsave(&port->lock, flags);
-       up->ier &= ~(UART_IER_RLSI | UART_IER_RDI);
-       serial_out(up, UART_IER, up->ier);
+       port->ops->stop_rx(port);
        priv->throttled = true;
        spin_unlock_irqrestore(&port->lock, flags);
 
@@ -727,6 +725,7 @@ static void omap_8250_unthrottle(struct uart_port *port)
        if (up->dma)
                up->dma->rx_dma(up);
        up->ier |= UART_IER_RLSI | UART_IER_RDI;
+       port->read_status_mask |= UART_LSR_DR;
        serial_out(up, UART_IER, up->ier);
        spin_unlock_irqrestore(&port->lock, flags);