scsi: target: iscsi: Free conn_ops when zalloc_cpumask_var failed
authortangwenji <tang.wenji@zte.com.cn>
Wed, 20 Mar 2019 14:14:44 +0000 (22:14 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 21 Mar 2019 00:38:07 +0000 (20:38 -0400)
It should not free cpumask but free conn->conn_ops when zalloc_cpumask_var
failed.

Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target_login.c

index c526e665f022886f9ce3af78bb3d60b85cefdc1a..683d04580eb32b0528e3be7bc5ab60daa29e994e 100644 (file)
@@ -1156,13 +1156,13 @@ static struct iscsi_conn *iscsit_alloc_conn(struct iscsi_np *np)
 
        if (!zalloc_cpumask_var(&conn->conn_cpumask, GFP_KERNEL)) {
                pr_err("Unable to allocate conn->conn_cpumask\n");
-               goto free_mask;
+               goto free_conn_ops;
        }
 
        return conn;
 
-free_mask:
-       free_cpumask_var(conn->conn_cpumask);
+free_conn_ops:
+       kfree(conn->conn_ops);
 put_transport:
        iscsit_put_transport(conn->conn_transport);
 free_conn: