mfd: stmfx: Fix error path in stmfx_chip_init

In error path, disable vdd regulator if it exists, but don't overload ret.
Because if regulator_disable() is successful, stmfx_chip_init will exit
successfully while chip init failed.

Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://lore.kernel.org/r/20230609092804.793100-1-amelie.delaunay@foss.st.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
index f30c7c3041477edea061b13d6b1b0ba94dc5e2d1..54cc902cb5785234fdc9fb47628b221f1f3af2f9 100644 (file)
--- a/drivers/mfd/stmfx.c
+++ b/drivers/mfd/stmfx.c
@@ -387,7 +387,7 @@ static int stmfx_chip_init(struct i2c_client *client)
 
 err:
        if (stmfx->vdd)
-               return regulator_disable(stmfx->vdd);
+               regulator_disable(stmfx->vdd);
 
        return ret;
 }