cifs: smb2 commands can not be negative, remove confusing check

As Coverity points out le16_to_cpu(midEntry->Command) can not be
less than zero.

Detected by CoverityScan, CID#1438650 ("Macro compares unsigned to 0")

Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>

diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 83ff0c25710d0861efad84a38d1da01948bbef54..5be7302853b6c55fe97b04339c39fd4d13567db6 100644 (file)
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -126,9 +126,11 @@ DeleteMidQEntry(struct mid_q_entry *midEntry)
        if ((slow_rsp_threshold != 0) &&
            time_after(now, midEntry->when_alloc + (slow_rsp_threshold * HZ)) &&
            (midEntry->command != command)) {
-               /* smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command */
-               if ((le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS) &&
-                   (le16_to_cpu(midEntry->command) >= 0))
+               /*
+                * smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command
+                * NB: le16_to_cpu returns unsigned so can not be negative below
+                */
+               if (le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS)
                        cifs_stats_inc(&midEntry->server->smb2slowcmd[le16_to_cpu(midEntry->command)]);
 
                trace_smb3_slow_rsp(le16_to_cpu(midEntry->command),